test(wtr): remove unnecessary support for .only files @W-19098252#5513
Merged
test(wtr): remove unnecessary support for .only files @W-19098252#5513
Conversation
instead of weird fake module
There's no setup/teardown needed, it's a single test, and WTR provides per-file encapsulation
working toward just importing and executing things, but not quite there yet
two env vars for the same goal is unnecessary
I think the last one was a concurrency related timeout, which was previously addressed.
helper files shouldn't have side effects; all setup should be in the setup file
no longer necessary
all tests are run in isolation
it's just one code blob now, not multiple scripts
ensures we never accidentally use the wrong one
Web Test Runner lets you specify individual files via CLI, so the workaround is not necessary.
jhefferman-sfdc
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.onlyfile hack was originally implemented for tests because there was no alternative way to focus on a single test.Web Test Runner allows you to specify a single file to execute (e.g .
yarn test:hydration test-hydration/some/test/index.spec.js), so this workaround is not necessary.Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item